Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multiple --<network> flags by an unique --network=<network> flag. #14202

Open
nalepae opened this issue Jul 10, 2024 · 2 comments
Open
Assignees
Labels
UX cosmetic / user experience related

Comments

@nalepae
Copy link
Contributor

nalepae commented Jul 10, 2024

🚀 Feature Request

Description

Prysm CLI primarily defines networks using --<network> flags.
Currently, these flags include --mainnet, --sepolia and --holesky.

  • Each time a new network is added, a corresponding --<network> flag needs to be introduced..
  • When a network is retired, its --<network> flag must be removed.

Proposed Solution

Prysm should implement a single --network=<network> flag. Presently, this would include options --network=mainnet, --network=sepolia and --network=holesky.

  • Prior to the release of Prysm V7, both the --<network> flags and the --network=<network> flag should coexist.
  • If a--<network> flag is used, a WARN log should appear, indicating that this flag will be deprecated in Prysm V7 and the --network=<network> flag should be used instead.
  • If both the --network=<network> flag and a --<network> flag are used simultaneously, the program should not start.
  • Upon the release of Prysm V7, all --<network> flags should be removed.

Targeted programs

  • Beacon node
  • Validator client
  • prysmctl
@nalepae nalepae added the UX cosmetic / user experience related label Jul 10, 2024
@nalepae nalepae self-assigned this Jul 10, 2024
@shyam-patel-kira
Copy link
Contributor

Can take this up

@nalepae nalepae assigned shyam-patel-kira and unassigned nalepae Jul 10, 2024
@shyam-patel-kira
Copy link
Contributor

@nalepae just noticed, there's already a chainId and NetworkID flags in the cmd/beacon-chain/flags/base.go

Am I supposed to replace it or just add it to other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX cosmetic / user experience related
Projects
None yet
Development

No branches or pull requests

2 participants