Too recent GitHub pull requests included

[susnux]

If I run:

% did --since 2024-02-18 --until 2024-02-25
Status report for given date range (2024-02-18 to 2024-02-25).

The report includes this pr: nextcloud/firstrunwizard#1105
Which was created: Feb 26, 2024, 6:15 PM GMT+1

This should not be included in the date range as the 26th is not in the range.

[Felixoid]

@psss I think it's because of these lines

did/did/cli.py

Lines 143 to 144 in 070a535

	# Make the 'until' limit inclusive
	opt.until.date += delta(days=1)

It looks like for github every self.options.until should have changed - delta(days=1). WDYT?

For example, /usr/bin/did --width=0 --since=2024-03-12 --until=2024-03-12 --format=markdown --debug generates the next snippet:

 INFO  Searching for pull requests created by Mikhail f. Shiryaev <[email protected]>
Mikhail f. Shiryaev <[email protected]>
 DEBUG  GitHub query: https://api.github.com/search/issues?q=author:Felixoid+created:2024-03-12..2024-03-13+type:pr&per_page=100

The given URL contains the next three PRs:

But what I need is actually this

Pay attention to the created:2024-03-12..2024-03-12 on the latter screenshot.

[Felixoid]

A solution is presented in 125f468