Reference tripple-slash directives in typings pollute global environment #409
Assignees
Labels
priority: low
This PR should be reviewed after all high and medium PRs.
status: in progress
This issue is being worked on.
type: chore
This PR contains changes that are not covered by other types (stylistic, dependency updates, etc).
Comments
|
Thank you for reaching out to us. There are no |
parfeon
added
status: in progress
|
Sounds good. But to be clear, if a |
parfeon
added a commit
that referenced
this issue
Oct 30, 2024
Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
parfeon
added a commit
that referenced
this issue
Oct 31, 2024
fix(types): fix `Actions` type definition Fix definition of type which represent message actions received from history and list of users which added action of specific type and value to the message. Closes #407 refactor(types): remove indexed signature for publish Remove redundant indexed signature from publish message parameters type definition. Closes #413 refactor(types): add serializable objects to `Payload` type Extend `Payload` type definition with objects which can be serialized by `JSON.stringify` using `toJSON()` methods. Closes #412 refactor(types): aggregate generated types definitions Aggregate multiple types definitions into single type definition type with proper type names and namespaces. Closes #405 #409 #410 refactor(types): add missing Subscribe Event Engine types Add Subscribe Event Engine and Event Listener types to the bundled types definition file. Closes #377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All
/// <reference .../>should be removed as they pollute the global environment.For reference: microsoft/TypeScript#33111
Superagent and many other packages have made the same mistake and also removed: DefinitelyTyped/DefinitelyTyped#57641
Mostly harmless in this case, but could cause conflicting Node.js typings to be referenced.
The text was updated successfully, but these errors were encountered: