Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Puppet major version selection #897

Open
d1nuc0m opened this issue Jul 15, 2024 · 3 comments
Open

Allow Puppet major version selection #897

d1nuc0m opened this issue Jul 15, 2024 · 3 comments

Comments

@d1nuc0m
Copy link

d1nuc0m commented Jul 15, 2024

Summary of the new feature
I think it would be useful to be able to also select a major version for puppet.editorService.puppet.version instead of a specific version.

For example, it is possible to specify to use 7.27.0, but as soon as the pdk is updated on the system, the extensions throws an error like Unable to use Puppet version '7.27.0' as it is not available. Using version '8.6.0' instead.. Sometimes only the choice of the major version, like 7.x, is relevant instead of the specific pdk release, so it'd be nice to be able to have a selection like 7.* instead of changing the editor settings at each update (I have tried expression like 7*, but to no result)

@LukasAud LukasAud closed this as completed by moving to Done in DevX Community Triage Jul 19, 2024
@d1nuc0m
Copy link
Author

d1nuc0m commented Jul 21, 2024

@jordanbreen28 @LukasAud as it was marked completed, is it possible to select a major Puppet version? Or is it a "won't fix" closure? 😅

@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Jul 22, 2024

@d1nuc0m ah; that was a mistake! I'll re-open! We do think this should make it's way into puppet-vscode, but have been unable to commit to this. If you think this is something you'd like to help out with, we'd be thrilled to accept a PR for this. Otherwise we will try get round to this when we can. Thanks @d1nuc0m

@jordanbreen28 jordanbreen28 reopened this Jul 22, 2024
@d1nuc0m
Copy link
Author

d1nuc0m commented Jul 23, 2024

ah; that was a mistake! I'll re-open!

Thanks a lot :D

If you think this is something you'd like to help out with, we'd be thrilled to accept a PR for this.

I've never worked on a vscode plugin, but I'll have a look at it and open a PR if I can get something promising - meanwhile can we keep the issue open if someone else is interested/can contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants