Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using frameworks? #219

Open
hamchapman opened this issue Jul 15, 2016 · 2 comments
Open

Switch to using frameworks? #219

hamchapman opened this issue Jul 15, 2016 · 2 comments
Labels

Comments

@hamchapman
Copy link
Contributor

hamchapman commented Jul 15, 2016

I imagine this will be one for @lukeredpath principally, but if others have opinions then please jump in.

Also, as a preface, I'm not massively familiar with the implications of changing the targets in libPusher from being static libraries to dynamic frameworks.

When looking into adding tvOS support I discovered that while SocketRocket supports it, ReactiveCocoa only added support for it in 4.0.0 (tangentially related: Reachability has support for it on master but 3.2, the latest release, doesn't have support for it).

However, upgrading ReactiveCocoa to 4.0.0 means that it becomes a framework and contains Swift code (targeting iOS 8.0+).

As such, what do you think about changing libPusher to build frameworks instead of static libraries and, as a consequence, target iOS 8.0+?

@hamchapman
Copy link
Contributor Author

I started exploring this to see what it would look like. You can see where I've got up to here: https://github.com/pusher/libPusher/tree/trying-out-using-frameworks

It's very much a WIP but you can see where it's heading.

@hamchapman
Copy link
Contributor Author

@lukeredpath can you share any insights on this? Would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant