Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe loading failure should result as an exception #261

Open
travnick opened this issue May 24, 2024 · 2 comments
Open

Recipe loading failure should result as an exception #261

travnick opened this issue May 24, 2024 · 2 comments

Comments

@travnick
Copy link

Currently, failure in loading a recipe by DeidRecipe class, generates WARNING Problem loading deid_default.recipe, skipping. log message only.

I consider this failure as an error, since my carefully handcrafted anonymization rules are not loaded, and the file is not processed correctly. Since this is the main point of the project, then it's an ERROR, not a WARNING

As it's the error, then the exception should be raised - further processing is not possible. Using any defaults in this case may lead to sensitive data leakage.
I'm aware of that project gives no guarantees. But currently, user is not able to handle the error in any way.

@vsoch
Copy link
Member

vsoch commented May 24, 2024

You could also just check to see that the recipe is not None on the class.

@travnick
Copy link
Author

Oh, ok, thank you! Considering this as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants