Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of "may be present" condition may be incorrect #29

Closed
mrbean-bremen opened this issue Aug 1, 2023 · 1 comment · Fixed by #35 or #36
Closed

Handling of "may be present" condition may be incorrect #29

mrbean-bremen opened this issue Aug 1, 2023 · 1 comment · Fixed by #35 or #36
Labels
Milestone

Comments

@mrbean-bremen
Copy link
Member

If the condition for a tag after "may be present" cannot be parsed, it should be handled as if it can always be present (same as "may be present otherwise"). Currently it is handled as "is not allowed", which is wrong (false positive).
This is also true for complex conditions, where only a part of the condition could be evaluated.

Seen in "General Series" module for Patient Position which has the condition:

Required for images where Patient Orientation Code Sequence (0054,0410) is not present and whose SOP Class is one of the following: CT ("1.2.840.10008.5.1.4.1.1.2") or MR ("1.2.840.10008.5.1.4.1.1.4") or Enhanced CT ("1.2.840.10008.5.1.4.1.1.2.1") or Enhanced MR Image ("1.2.840.10008.5.1.4.1.1.4.1") or Enhanced Color MR Image ("1.2.840.10008.5.1.4.1.1.4.3") or MR Spectroscopy ("1.2.840.10008.5.1.4.1.1.4.2") Storage SOP Classes. May be present for other SOP Classes if Patient Orientation Code Sequence (0054,0410) is not present.

mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 8, 2023
- fixes pydicom#29
- the test was already present, but had a wrong expectation
mrbean-bremen added a commit that referenced this issue Aug 8, 2023
- fixes #29
- the test was already present, but had a wrong expectation
@mrbean-bremen
Copy link
Member Author

Still not correct - the test checks the wrong value...

@mrbean-bremen mrbean-bremen reopened this Aug 9, 2023
@mrbean-bremen mrbean-bremen added this to the 0.4 milestone Aug 9, 2023
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 11, 2023
- fixes pydicom#29
- add option --recreate-json for testing purposes
mrbean-bremen added a commit that referenced this issue Aug 12, 2023
- fixes #29
- add option --recreate-json for testing purposes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant