Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions without an "otherwise" clause are handled too strict #38

Closed
mrbean-bremen opened this issue Aug 13, 2023 · 0 comments · Fixed by #40
Closed

Conditions without an "otherwise" clause are handled too strict #38

mrbean-bremen opened this issue Aug 13, 2023 · 0 comments · Fixed by #40
Labels
Milestone

Comments

@mrbean-bremen
Copy link
Member

Mostly, a "required" condition also has a clause if it is allowed if the condition is not fullfilled ("may be present otherwise", "shall not be present otherwise", "may be present otherwise if...").
Sometimes this clause is omitted. This case is currently handled as "should not be present otherwise", but should be handled as "may be present otherwise" to avoid false positives.

@mrbean-bremen mrbean-bremen added this to the 0.4 milestone Aug 13, 2023
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 13, 2023
- fixes pydicom#38
- ignore private tags during validation
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 13, 2023
- fixes pydicom#38
- ignore private tags during validation
mrbean-bremen added a commit that referenced this issue Aug 13, 2023
- fixes #38
- ignore private tags during validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant