Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include conditions not handled #39

Closed
mrbean-bremen opened this issue Aug 13, 2023 · 0 comments · Fixed by #43
Closed

Include conditions not handled #39

mrbean-bremen opened this issue Aug 13, 2023 · 0 comments · Fixed by #43
Labels
enhancement
Milestone
0.5

Comments

@mrbean-bremen
Copy link
Member

In the Document Content Macro there are conditions for when to include a macro depending on the value of "ValueType".
These are currently not handled, creating a lot of false positives in validating SR documents which use this macro.
@mrbean-bremen mrbean-bremen added this to the 0.5 milestone Aug 13, 2023
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 20, 2023
@mrbean-bremen
Add handling of conditional includes
c71b85a 
- needed for validation of SR Document Content
- closes pydicom#39
@mrbean-bremen mrbean-bremen mentioned this issue Aug 20, 2023
Merged
mrbean-bremen added a commit to mrbean-bremen/dicom-validator that referenced this issue Aug 20, 2023
@mrbean-bremen
Add handling of conditional includes
760dc62 
- needed for validation of SR Document Content
- closes pydicom#39
mrbean-bremen added a commit that referenced this issue Aug 22, 2023
@mrbean-bremen
Add handling of conditional includes
1f01f5f 
- needed for validation of SR Document Content
- closes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Add handling of conditional includes mrbean-bremen/dicom-validator
1 participant
@mrbean-bremen