-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License info no longer included in METADATA #1804
Comments
That's not true actually, PyPI hard rejects such uploads which is why I pushed the fix over the weekend #1786 |
Interesting 🤔 I've definitely seen projects which for which the upload with Would the backfill to the |
I'm not exactly against the backfill idea but are you able to wait <2 weeks until that is merged? One of the maintainers said that it would be merged "in the next week or so". |
Just saw #1805. Thanks a lot!
I tried to reproduce it today, just because I'm involved with the setuptools implementation of PEP 639, but couldn't. The upload to PyPI even with Setuptools (currently) includes a non-spec version of |
To be clear. It fails the metadata validation with |
Oh good point! The rollout might be gradual which would explain the inconsistent error. |
A few projects I know have started to adopt the new
project.license
syntax recommended in the docs https://hatch.pypa.io/1.9/config/metadata/#license. Withhatchling==1.25.0
this would include aLicense-Expression
key in theMETADATA
file.This was change in #1790 + #1792 and now these project neither include
License-Expression
nor the "old"License
key meaning the license information (which is specified correctly) is just lost.I understand that technically
License-Expression
is only added with metadata version2.4
which isn't supported by PyPI yet. However, it's fine to still include it in older versions as well (it will just get ignored by PyPI and not be validated on upload). The isn't a big issue though as hatchling already validates it.If that's not an option, might I recommend to backfill the
License
key with the SPDX expression instead (temporarily). That would be equivalent to using the "old" syntax with textproject = {text = "MIT"}
. I don't think it makes much sense for projects to revert back to the old syntax themselves only to change it again once support for PyPI lands.The text was updated successfully, but these errors were encountered: