Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2 Electrolysis and Fuel cells and buses are re-added (Same for battery) #1196

Open
2 tasks done
yerbol-akhmetov opened this issue Nov 15, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@yerbol-akhmetov
Copy link
Collaborator

Checklist

  • I am using the current main branch or the latest release. Please indicate.
  • I am running on an up-to-date pypsa-earth environment. Update via conda env update -f envs/environment.yaml.

Describe the Bug

Good day. Here I would like to report potential bug in add_hydrogen function of prepare_sector_networks, In particular, H2 Fuel Cell, H2 Electrolysis and H2 buses are readded, which causes error message as warning. So they effectively are not added, because they are already in the network.

Example, we have H2 electrolysis addition in add_extra_components:

        n.madd(
            "Link",
            h2_buses_i + " Electrolysis",
            bus0=buses_i,
            bus1=h2_buses_i,
            carrier="H2 electrolysis",
            p_nom_extendable=True,
            efficiency=costs.at["electrolysis", "efficiency"],
            capital_cost=costs.at["electrolysis", "capital_cost"],
            marginal_cost=costs.at["electrolysis", "marginal_cost"],
        )

In prepare_sector_network we have:

        n.madd(
            "Link",
            nodes + " H2 Electrolysis",
            bus1=nodes + " H2",
            bus0=nodes,
            p_nom_extendable=True,
            carrier="H2 Electrolysis",
            efficiency=costs.at["electrolysis", "efficiency"],
            capital_cost=costs.at["electrolysis", "fixed"],
            lifetime=costs.at["electrolysis", "lifetime"],
        )

@davide-f

Error Message

image

@yerbol-akhmetov yerbol-akhmetov added the bug Something isn't working label Nov 15, 2024
@yerbol-akhmetov yerbol-akhmetov changed the title H2 Electrolysis and Fuel cells and buses are re-added H2 Electrolysis and Fuel cells and buses are re-added (Same for battery) Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant