Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group data (using comps.xml) should be used when showing the command with -c #8

Open
rothgar opened this issue May 16, 2016 · 3 comments

Comments

@rothgar
Copy link
Contributor

rothgar commented May 16, 2016

If you run upstream_sync with --command it shows the command but the actual code will check if a comps.xml file exists and if it does it will append -g /repo/path/comps.xml
The file should be checked for even when only viewing the reposync and createrepo command.

@rothgar
Copy link
Contributor Author

rothgar commented May 16, 2016

I plan to make this change at some point but wanted to document it here to have something to work with.

@pyther
Copy link
Owner

pyther commented May 24, 2016

Generally I think this is a good idea. However, this could be a bit tricky to implement.

  • /repo/path/comps.xml won't exist before a sync
  • there is no way to know if the source (rsync, reposync) will have comps.xml
  • if comps.xml exists before sync, there is no guarantee it will exist after a sync (deleted from remote server)

What does createrepo do if comps.xmldoesn't exist? Does it fail?

@rothgar
Copy link
Contributor Author

rothgar commented May 24, 2016

The code currently just looks for the file and uses it if it exists. I would use the same code block for showing the command too.

https://github.com/pyther/upstream_sync/blob/master/upstream_sync.py#L403-L406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants