-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keycloak ID key change #854
Comments
I've created a revert PR (#858) since a fix PR doesn't seem to be forthcoming. |
I am sorry for the disagreement, I really wasn't thinking this would be hardcoded in utils. I still believe having a way to configure the I unfortunately don't have time to provide a fix in the upcoming week, would someone else have some time to investigate? |
@nijel, what's the path forward here? |
@nijel, friendly ping - it's been a week. Can we merge the revert PR please so this unblocks releasing a new version? |
I've merged that, given we don't have a better solution for now. #862 is the issue to track this feature. |
Expected behaviour
Upgrade from 4.4.2 to 4.5.0 changes behavior of Keycloak authentication, see WeblateOrg/docker#2048.
Actual behaviour
#815 by @derlin is probably the root cause here:
It removes ID_KEY from the backend, makes it effectively use value from a parent class:
social-core/social_core/backends/oauth.py
Line 43 in b9d9937
While this attribute is still used in the partial pipeline:
social-core/social_core/utils.py
Lines 192 to 200 in b9d9937
Any other comments?
Possible solutions:
There is at least one additional backend (Seznam) affected by this.
The text was updated successfully, but these errors were encountered: