-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We don't have a dedicated Windows bot with disabled symlinks #454
Comments
Strange, I don't recall that I changed this option in my Windows 11 VM and I can create symlinks. Does test.pythoninfo log this "Windows Developer Mode" info? I'm curious, do you have info on this mode, how to check if it's enabled or not, and how to turn it on or off? |
How did you install the VM? Is it a development image? I suggest that you search the Web for Windows developer mode; when it comes to info about Windows, its better than asking me :) |
Hum, I don't recall. Maybe yes, maybe no. https://learn.microsoft.com/en-us/windows/apps/get-started/enable-your-device-for-development says:
Ah. Maybe installed Visual Studio installs it. So any Windows machine where Python is built with VS has this mode enabled? Good to know. The issue title is:
How would Python be built in this case? If VS requires the developer mode to be enabled? Or another kind of test is needed: get pre-built Python, run tests. That's way more complicated than just "set up a Windows buildbot" since something should frequently build Python on Windows with whatever is needed to run tests (including Python source code?). |
Well, |
Oh. That's even more interesting. |
I wrote python/cpython#114121 to log the Windows Developer Mode in test.pythoninfo. From what I saw, os.symlink() is allowed if the user is running with Administrator rights or if the Developer Mode is enabled. I checked again my Windows 11 VM: in fact, the Developer Mode was disabled, and os.symlink() was disallowed. Moreover, |
Oh. I got confused by something... I'm mostly working on Windows via SSH. But SSH logs me as an administrator. In this case, can_symlink() returns True, even if the Developer Mode is enabled :-) I modified my PR to also log if the user is an adminstrator or not. |
Recently, a missing
@skip_unless_symlink
was caught by a single buildbot --AMD64 Windows11 Refleaks
: python/cpython#114107Given that no-symlinks (i.e. “developer mode” disabled) is the default on Widows, we should probably have a dedicated builder for it.
Unfortunately I'm currently not in a position to fix this.
The text was updated successfully, but these errors were encountered: