Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max linker memory being set for wasi thread builds #121108

Open
brettcannon opened this issue Jun 27, 2024 · 2 comments
Open

Max linker memory being set for wasi thread builds #121108

brettcannon opened this issue Jun 27, 2024 · 2 comments
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error

Comments

@brettcannon
Copy link
Member

brettcannon commented Jun 27, 2024

Bug report

Bug description:

The max memory for WASI thread builds is set at:

https://github.com/python/cpython/blob/1a2e7a747540f74414e7c50556bcb2cc127e9d1c/configure.ac#L2408C59-L2408C67

But that's not enough for a build anymore:

https://github.com/brettcannon/cpython-wasi-build/actions/runs/9704017614/job/26783382753#step:7:3581

Either the limit needs to increase to at least 20971520 or be dropped entirely (probably the latter).

CPython versions tested on:

CPython main branch

Operating systems tested on:

Other

@brettcannon brettcannon added type-bug An unexpected behavior, bug, or error build The build process and cross-build OS-wasi labels Jun 27, 2024
@brettcannon
Copy link
Member Author

dicej@118e9d8 suggests the settings might not even be necessary anymore.

@brettcannon
Copy link
Member Author

Along the way the target triple should get updated to wasm32-wasip1-threads once #123877 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build OS-wasi type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

1 participant