"Check if generated files are up to date" job misses regen-unicodedata
and regen-limited-abi
#126524
Labels
regen-unicodedata
and regen-limited-abi
#126524
Feature or enhancement
Currently our
regen-all
is missing severalregen-
targets:While our CI job to check regenerated files does not check them:
cpython/.github/workflows/build.yml
Lines 120 to 124 in 2a6b6b3
This does not seem right, I think that we should add:
make regen-unicodedata
(it requires internet access, but GitHub jobs always have access, see gh-96954: Don't run regen-unicodedata in regen-all #112120)make regen-limited-abi
(needs to compile python to get the ABI)How long does it work? Testing locally first:
I propose adding these two
make
targets to the test to be extra safe.What do others think? :)
If agreed, I will send a PR.
The text was updated successfully, but these errors were encountered: