Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_release.py broken for 3.12 and earlier because of bytecode magic number check #155

Open
Yhg1s opened this issue Aug 6, 2024 · 1 comment

Comments

@Yhg1s
Copy link
Member

Yhg1s commented Aug 6, 2024

During the release of 3.12.5:

💥  Checking the magic number is up-to-date
Traceback (most recent call last):
  File "./run_release.py", line 1283, in <module>
    main()
  File "./run_release.py", line 1279, in main
    automata.run()
  File "./run_release.py", line 244, in run
    raise e from None
  File "./run_release.py", line 241, in run
    self.current_task(self.db)
  File "release.py", line 126, in __call__
    return getattr(self, "function")(db)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "./run_release.py", line 402, in check_magic_number
    magic_actual = get_magic(magic_actual_file, magic_actual_re)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "./run_release.py", line 391, in get_magic
    if m := regex.search(source.read_text()):
                         ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/pathlib.py", line 1059, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/pathlib.py", line 1045, in open
    return io.open(self, mode, buffering, encoding, errors, newline)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'cpython/Include/internal/pycore_magic_number.h'
@Yhg1s
Copy link
Member Author

Yhg1s commented Sep 6, 2024

Actually, it's also broken for 3.13 because pycore_magic_number.h doesn't exist there, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant