From b0ba165fa0b562c3bbebfb95c0b730007053d442 Mon Sep 17 00:00:00 2001
From: andrewkh <andrewkh@devgpu003.cco1.facebook.com>
Date: Wed, 25 Sep 2024 12:22:51 -0700
Subject: [PATCH] only msvc

---
 third_party/CMakeLists.txt | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
index 695a98907..8d6eddaf6 100644
--- a/third_party/CMakeLists.txt
+++ b/third_party/CMakeLists.txt
@@ -60,12 +60,26 @@ else()
     list(APPEND AWSSDK_LIBRARIES "${aws_cpp_sdk_INSTALL}/lib/libs2n.a")
   endif()
 
+  set(
+    cmake_args
+    "-DBUILD_SHARED_LIBS=OFF"
+    "-DBUILD_ONLY=transfer;s3"
+    "-DENABLE_TESTING=OFF"
+    "-DCMAKE_BUILD_TYPE=Release"
+    "-DCMAKE_INSTALL_PREFIX=${aws_cpp_sdk_INSTALL}"
+    "-DCMAKE_INSTALL_LIBDIR=lib"
+  )
+
+  if(MSVC)
+    list(APPEND cmake_args "-DCMAKE_CXX_FLAGS=/W3 /WX")
+  endif()
+
   include(ExternalProject)
   ExternalProject_Add(
     aws_sdk
     SOURCE_DIR ${aws_cpp_sdk_SOURCE_DIR}
     INSTALL_DIR ${aws_cpp_sdk_INSTALL}
-    CMAKE_ARGS "-DBUILD_SHARED_LIBS=OFF" "-DBUILD_ONLY=transfer;s3" "-DENABLE_TESTING=OFF" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=${aws_cpp_sdk_INSTALL}" "-DCMAKE_INSTALL_LIBDIR=lib" "-DCMAKE_CXX_FLAGS=\W3 \WX"
+    CMAKE_ARGS ${cmake_args}
     BUILD_BYPRODUCTS ${AWSSDK_LIBRARIES}
     )
 endif()