Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stateful DataLoader] CI takes too long for Mac and WIndows #1338

Open
andrewkho opened this issue Oct 16, 2024 · 0 comments
Open

[Stateful DataLoader] CI takes too long for Mac and WIndows #1338

andrewkho opened this issue Oct 16, 2024 · 0 comments

Comments

@andrewkho
Copy link
Contributor

🐛 Describe the bug

CI for Ubuntu / Linux in stateful dataloader takes about 20 seconds, but for mac and windows takes about 30+ minutes. Not only burning a huge amount of CI compute budget but slowing down iteration.

Linux probably runs so quickly because it's able to fork a process instead of spawning. The reason not to drop them is if the CI would have caught bugs that would not appear on Linux tests, and since we're not building native code in Stateful DataLoader, I'd assume it's unlikely.

Versions

Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant