From 6872133e69e80f43e7ee0f784b758a811abc4ce8 Mon Sep 17 00:00:00 2001 From: vfdev Date: Thu, 17 Oct 2024 20:05:05 +0000 Subject: [PATCH] Fixed mypy failures on the CI --- ignite/handlers/time_profilers.py | 8 ++++---- ignite/handlers/visdom_logger.py | 8 ++++---- ignite/handlers/wandb_logger.py | 2 +- ignite/metrics/fbeta.py | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ignite/handlers/time_profilers.py b/ignite/handlers/time_profilers.py index 38427aab0e4..76f560e050a 100644 --- a/ignite/handlers/time_profilers.py +++ b/ignite/handlers/time_profilers.py @@ -400,7 +400,7 @@ def print_results(results: Dict) -> str: """ - def to_str(v: Union[str, tuple]) -> str: + def to_str(v: Union[str, tuple, int, float]) -> str: if isinstance(v, str): return v elif isinstance(v, tuple): @@ -412,12 +412,12 @@ def odict_to_str(d: Mapping) -> str: return out others = { - k: odict_to_str(v) if isinstance(v, OrderedDict) else v for k, v in results["event_handlers_stats"].items() + k: odict_to_str(v) if isinstance(v, OrderedDict) else to_str(v) for k, v in results["event_handlers_stats"].items() } others.update(results["event_handlers_names"]) - output_message = """ + output_message: str = """ ---------------------------------------------------- | Time profiling stats (in seconds): | ---------------------------------------------------- @@ -430,7 +430,7 @@ def odict_to_str(d: Mapping) -> str: {dataflow_stats} Event handlers: -{total_time:.5f} +{total_time} - Events.STARTED: {STARTED_names} {STARTED} diff --git a/ignite/handlers/visdom_logger.py b/ignite/handlers/visdom_logger.py index 315191c3984..c820d343a6e 100644 --- a/ignite/handlers/visdom_logger.py +++ b/ignite/handlers/visdom_logger.py @@ -150,7 +150,7 @@ def __init__( **kwargs: Any, ): try: - import visdom + import visdom # type: ignore[import-not-found] except ImportError: raise ModuleNotFoundError( "This contrib module requires visdom package. " @@ -187,7 +187,7 @@ def __init__( self.vis = visdom.Visdom(server=server, port=port, raise_exceptions=raise_exceptions, **kwargs) - if not self.vis.offline and not self.vis.check_connection(): # type: ignore[attr-defined] + if not self.vis.offline and not self.vis.check_connection(): raise RuntimeError(f"Failed to connect to Visdom server at {server}. Did you run python -m visdom.server ?") self.executor: Union[_DummyExecutor, "ThreadPoolExecutor"] = _DummyExecutor() @@ -195,7 +195,7 @@ def __init__( self.executor = ThreadPoolExecutor(max_workers=num_workers) def _save(self) -> None: - self.vis.save([self.vis.env]) # type: ignore[attr-defined] + self.vis.save([self.vis.env]) def close(self) -> None: self.executor.shutdown() @@ -240,7 +240,7 @@ def add_scalar( kwargs = { "X": [global_step], "Y": [v], - "env": logger.vis.env, # type: ignore[attr-defined] + "env": logger.vis.env, "win": self.windows[k]["win"], "update": update, "opts": self.windows[k]["opts"], diff --git a/ignite/handlers/wandb_logger.py b/ignite/handlers/wandb_logger.py index 89675c00fe7..cc1e533b2dd 100644 --- a/ignite/handlers/wandb_logger.py +++ b/ignite/handlers/wandb_logger.py @@ -125,7 +125,7 @@ def score_function(engine): def __init__(self, *args: Any, **kwargs: Any): try: - import wandb + import wandb # type: ignore[import-not-found] self._wandb = wandb except ImportError: diff --git a/ignite/metrics/fbeta.py b/ignite/metrics/fbeta.py index 6522efc6423..63f822fe3a5 100644 --- a/ignite/metrics/fbeta.py +++ b/ignite/metrics/fbeta.py @@ -151,7 +151,7 @@ def thresholded_output_transform(output): if precision is None: precision = Precision( - output_transform=(lambda x: x) if output_transform is None else output_transform, # type: ignore[arg-type] + output_transform=(lambda x: x) if output_transform is None else output_transform, average=False, device=device, ) @@ -160,7 +160,7 @@ def thresholded_output_transform(output): if recall is None: recall = Recall( - output_transform=(lambda x: x) if output_transform is None else output_transform, # type: ignore[arg-type] + output_transform=(lambda x: x) if output_transform is None else output_transform, average=False, device=device, )