import guard for TorchAO not working in fbcode #1855
Comments
|
@ebsmothers can you take a look at this, i'm going to put a PR up to handle BC briefly so we can move forward with our diff train but i don't think this should be gated on fbcode, just torchao version. |
HDCharles
added a commit
to pytorch/ao
that referenced
this issue
Oct 16, 2024
Summary: trying to land diff train, this is causing issues until torchtune can correct their version guard, issue: pytorch/torchtune#1855 Test Plan: see CI Reviewers: Subscribers: Tasks: Tags:
|
@HDCharles this is the version I had added initially. The current version was added by @jerryzh168 in #1834, maybe the two of you can iron this out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/pytorch/torchtune/blob/7d29c21149ace4be9fdc2709a03c0a21ba191010/torchtune/utils/_import_guard.py#L20C1-L29C2
_USE_NEW_TENSOR_CORE_TILED_LAYOUT_API = _is_fbcode() or (
not _is_fbcode()
and (
("dev" not in torchao_version and torchao_version >= "0.6.0")
or (
"dev" in torchao_version
and _nightly_version_ge(torchao_version, "2024-10-10")
)
)
The text was updated successfully, but these errors were encountered: