You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the loss ForwardKLWithChunkedOutputLoss is averaged over the chunks which I think is not the right way to do it since there are chunks that contains only pad tokens. line
I think the right way to do it is to average over the total non pad tokens. I did the fix here but couldn't open a pull request because my commit didn't pass the test since the loss did not match with the expected loss.
The text was updated successfully, but these errors were encountered:
Thank you for pointing this out. You should be able to submit a PR even if the tests don't pass. Before landing the PR, you'll need to verify that training is improved and then you can update the loss values in the test too.
Hi there,
Currently the loss ForwardKLWithChunkedOutputLoss is averaged over the chunks which I think is not the right way to do it since there are chunks that contains only pad tokens. line
I think the right way to do it is to average over the total non pad tokens. I did the fix here but couldn't open a pull request because my commit didn't pass the test since the loss did not match with the expected loss.
The text was updated successfully, but these errors were encountered: