Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - intermediate_source/torch_export_tutorial.py fails against 2.4 RC binaries #2940

Open
brycebortree opened this issue Jun 18, 2024 · 3 comments

Comments

@brycebortree
Copy link

brycebortree commented Jun 18, 2024

Add Link

https://pytorch.org/tutorials/intermediate/torch_export_tutorial.html

Describe the bug

The intermediate_source/torch_export_tutorial.py is failing with the following error message:

Unexpected failing examples:
2024-06-17T23:56:15.4845763Z /var/lib/workspace/intermediate_source/torch_export_tutorial.py failed leaving traceback:
2024-06-17T23:56:15.4846533Z Traceback (most recent call last):
2024-06-17T23:56:15.4847335Z   File "/var/lib/workspace/intermediate_source/torch_export_tutorial.py", line 208, in <module>
2024-06-17T23:56:15.4848156Z     bad2_nonstrict = export(Bad2(), (torch.randn(3, 3),), strict=False)
2024-06-17T23:56:15.4849146Z   File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/export/__init__.py", line 174, in export
2024-06-17T23:56:15.4849883Z     return _export(
2024-06-17T23:56:15.4850608Z   File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/export/_trace.py", line 945, in wrapper
2024-06-17T23:56:15.4851330Z     raise e
2024-06-17T23:56:15.4852033Z   File "/opt/conda/envs/py_3.10/lib/python3.10/site-packages/torch/export/_trace.py", line

link to build

Describe your environment

  • Pytorch version 2.4
  • CUDA 12
  • CI

cc @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4

@brycebortree
Copy link
Author

@angelayi

@svekars
Copy link
Contributor

svekars commented Jun 18, 2024

@williamwen42 @zhxchen17

@angelayi
Copy link
Contributor

angelayi commented Jun 18, 2024

@tugsbayasgalan this is a regression of having pre-dispatch export. This now fails with pre-dispatch export:

class Bad2(torch.nn.Module):
    def forward(self, x):
        x.data[0, 0] = 3
        return x

bad2_nonstrict = export(Bad2(), (torch.randn(3, 3),), strict=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants