You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm more than happy to follow the contribution guide (already started), but wasn't sure if I should open an issue or not.
One issue I did find is some inconsistency between variable types used for image mean and standard deviation. Specifically in FasterRCNN the typing uses Tuple[float, float, float] (Link) but if it is not defined then a set of values are defined in the code and it assigns a list
My recommendation is that in this case a Tuple[float, float, float] is more precise in the case that you are expecting 3 channel values, and there wouldn't be expected reason to modify those values inside the function.
🚀 The feature
In support of #2025, add type hinting to
torchvision/models/detection/faster_rcnn
Motivation, pitch
In an effort to get type hinting throughout torchvision, I wanted to start contributing small where I could.
Alternatives
Not needed
Additional context
No response
The text was updated successfully, but these errors were encountered: