Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torrents auto-downloaded by RSS rules not obeying "Excluded file names" in Preferences #21508

Closed
wind77 opened this issue Oct 4, 2024 · 26 comments
Labels
RSS RSS-related issues/changes

Comments

@wind77
Copy link

wind77 commented Oct 4, 2024

qBittorrent & operating system versions

qBittorrent v5.0.0 (64-bit)
Qt: 6.7.3
Libtorrent: 1.2.19.0
Boost: 1.86.0
OpenSSL: 3.1.7
zlib: 1.3.1

What is the problem?

This is my Preferences on Excluded file names.

image

The settings work fine on manually added torrents.
image

But since v5.0, I noticed that in torrents auto-downloaded by RSS rules, the Preferences were no longer obeyed:
image

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

NA

@glassez
Copy link
Member

glassez commented Oct 4, 2024

Cannot confirm.

@thalieht thalieht added the RSS RSS-related issues/changes label Oct 4, 2024
@ophelpsWU
Copy link

I'm having the same issue with Magnet added torrents - the exclude parameters are not working

@glassez
Copy link
Member

glassez commented Oct 5, 2024

I'm having the same issue with Magnet added torrents - the exclude parameters are not working

I can't confirm it either. I just checked - it works correctly for me.

@glassez
Copy link
Member

glassez commented Oct 5, 2024

You may be specified incorrect patterns...

@wind77
Copy link
Author

wind77 commented Oct 5, 2024

You may be specified incorrect patterns...

In my 1st post, I already specified the patterns I used, and screenshot the outcome to prove that it doesn't work on RSS articles.

But, apparently, you are always in a state of denial.

A bug was reported, and you denied it.

Cannot confirm.

@ophelpsWU confirmed the bug, and you denied it as well.

I can't confirm it either. I just checked - it works correctly for me.

Similarly, in #21484 (comment),
I reported another issue, and you brushed off the issue:

The behavior has been like this for quite some time.
At least it's the same in previous branch.

When @thalieht confirmed the issue, you started to fume toxic:

This is a useless conversation

Is such toxicity in this Github, getting common, or getting tolerated because you're one of the developer?

@glassez
Copy link
Member

glassez commented Oct 5, 2024

you started to fume toxic:

This is a useless conversation

Why try to accuse me of toxicity by speculating with a phrase taken out of context?
There is no toxicity. Only brief answers "to the point".
I generally try not to show emotion, at least until the other person intends to conduct the conversation in such a disrespectful tone.

In my 1st post, I already specified the patterns I used, and screenshot the outcome to prove that it doesn't work on RSS articles.

This does not mean that the problem is in the RSS. As I said, the problem may be in the pattern itself, which does not match some file name.

A bug was reported, and you denied it.

Cannot confirm.

I didn't deny it.
I took my time and tested it out. And my test couldn't confirm the problem in general, which I reported.

@ophelpsWU confirmed the bug, and you denied it as well.

I can't confirm it either. I just checked - it works correctly for me.

One more time. I tested it out. It applies the exclude patterns to both torrent files and magnet links, both added manually and automatically by RSS downloader.
Therefore, I made the following conclusion:

You may be specified incorrect patterns...

But if you intend to accuse me of toxicity, etc., then I would prefer not to participate in these discussions anymore. Maybe someone more "polite" will help you.

@thalieht

This comment was marked as off-topic.

@freitasm
Copy link

freitasm commented Oct 8, 2024

I confirm this happens with v5.0.0, with both torrents initiated from RSS feeds or search results.

The filter list below worked before this update. Now, these files are being downloaded as well:

*.exe
*.nfo
*.txt
*.jpg
*.jpeg
*.png
*.gif
*.scr

Cheers

@TomasDvorsky
Copy link

Confirming the same issue.
image
Before v5.0.0 qBittorrent just didn't create the files that I can now see - the highlighted 3. Now I have to delete them manually whenever a download is complete.

@glassez
Copy link
Member

glassez commented Oct 8, 2024

@freitasm, @TomasDvorsky
How does these files look in qBittorrent? Are they checked or unchecked?

@TomasDvorsky
Copy link

It looks like they are unchecked.
image

@freitasm
Copy link

freitasm commented Oct 8, 2024

Mine appear checked.

@glassez
Copy link
Member

glassez commented Oct 8, 2024

It looks like they are unchecked. image

So you are under another (well known) regression of v5.0. It already has a fix that will be included in v5.0.1. You can disable applying "mark-of-the-web" in advanced settings until then.

@Matth7878
Copy link

Same here.
Triggering manually from RSS don't check files excluded but when it's triggered from an rss auto download rule it is.

@glassez
Copy link
Member

glassez commented Oct 9, 2024

Can someone provide a real example for investigation, i.e. real RSS feed, real rule and real list of excluded file names?

@david9039
Copy link

Can someone provide a real example for investigation, i.e. real RSS feed, real rule and real list of excluded file names?

Using Magnet links. This has happened on every download that has an .nfo file since the upgrade to 5.0.

qbit 3

Setting carried over from previous version of Qbit.

qbit 1

Display showing that the .nfo file is unchecked and noted as Not Downloaded

qbit 2

The .nfo file was actually downloaded.

@glassez
Copy link
Member

glassez commented Oct 10, 2024

Display showing that the .nfo file is unchecked and noted as Not Downloaded

See #21508 (comment).

I was asking for an example from those people who keep claiming that "when it's triggered from an rss auto download rule" files are still checked.

@wind77
Copy link
Author

wind77 commented Oct 10, 2024

I was asking for an example from those people who keep claiming that "when it's triggered from an rss auto download rule" files are still checked.

You were asking what I have provided in the 1st post?

But since v5.0, I noticed that in torrents auto-downloaded by RSS rules, the Preferences were no longer obeyed: image

@glassez
Copy link
Member

glassez commented Oct 10, 2024

You were asking what I have provided in the 1st post?

No.
I was asking for some particular example that I can investigate, i.e. real RSS feed URL, real auto downloading rule definition and real excluded file names that cause this problem for one of affected people. As I said above, I was unable to reproduce this problem using arbitrary input data.

@wind77
Copy link
Author

wind77 commented Oct 10, 2024

real auto downloading rule definition and real excluded file names that cause this problem

i screenshot the rules and the file names, for reference.

arbitrary input data.

i dunno why my screenshots were called "arbitrary".
Exactly what I need to provide, to help u to reproduce the outcome?

@glassez
Copy link
Member

glassez commented Oct 10, 2024

arbitrary input data.

i dunno why my screenshots were called "arbitrary".

Were they?
I just took an arbitrary RSS feed, and created an arbitrary rule that would be guaranteed to work on this RSS feed, and I added an arbitrary list of excluded filenames based on those files that occur in the torrents matched by this rule. And it worked as expected, i.e. torrents were added and matching files were excluded.

So now I want to test exactly your RSS feed, your rule and your exclusion list.

@c11umw
Copy link

c11umw commented Oct 13, 2024

Can confirm - files selected for exclusion are being downloaded when they should not.
It's almost like the preference settings are delayed and as they're small files they download before the app can ignore them.

Was working on V4*
Noticed since V5

Perhaps it's something with legacy settings where they didn't convert over to V5 config quite right?
(just an idea)

@glassez
Copy link
Member

glassez commented Oct 13, 2024

Perhaps it's something with legacy settings where they didn't convert over to V5 config quite right?
(just an idea)

No.

Can confirm - files selected for exclusion are being downloaded when they should not.
It's almost like the preference settings are delayed and as they're small files they download before the app can ignore them.

The same question that was asked earlier in this thread. What do the files that should be excluded look like in torrent content view, as excluded (i.e. unchecked and having "Do not download" priority) or as having the "Normal" download priority?

@wind77
Copy link
Author

wind77 commented Oct 13, 2024

Downgrade to earlier version solved the issue.
Save all the time and nonsense.
Case closed.

@wind77 wind77 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
@glassez
Copy link
Member

glassez commented Oct 13, 2024

Anyone who has the problem with excluded files, and it really is not the one mentioned in this comment, please open a new Issue (apparently, the author of this thread does not intend to continue a constructive dialogue and provide the necessary feedback).

@zybexXL
Copy link

zybexXL commented Oct 17, 2024

Fixed by #21628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RSS RSS-related issues/changes
Projects
None yet
Development

No branches or pull requests

10 participants