Fix Accumulating Cell Merge Info While formatWorkbook #143
Conversation
| @@ -251,6 +251,7 @@ formatWorkbook nfcss initStyle = extract go | |||
| initSt = stateFromStyleSheet initStyle | |||
| go = flip runState initSt $ | |||
| forM nfcss $ \(name, fcs) -> do | |||
| modify (\s -> s { _formattingMerges = [] }) -- We do not want merge information to accumulate across sheets. | |||
There was a problem hiding this comment.
Hi @vst
Thanks for the issue and the PR
Your fix does resolve the problem but I think that we fix the root of this problem and not just use this workaround.
I think that the main issue here is that Formatted should be probably named something like FormattedSheet because while it contains workbook level style sheet at the same time it includes worksheet level data - cells and merges. And thus forM use in this go helper isn't a quite correct thing - the code shouldn't start with some data form the previous worksheet.
Would you like to work on a better fix here? And if we need to rename some types we could release it as a new major version of the library.
In any case thanks for the contribution
There was a problem hiding this comment.
Thanks for quick response, @qrilka.
I agree with you. It must be more coherent.
I would love to work on it as you suggested, but I can not promise a target date within the next few weeks.
- You may wish to close this PR. I can leave some instructions to the related issue for current users so that they can live with the current version until we implement a proper fix.
- You may merge this as an interim solution, but I am afraid of inertia it may cause :)
- In the meantime, I will study the code, play with the types and ways to avoid what
forMdoes as you suggested.
There was a problem hiding this comment.
I think there's no rush so you could take your time, thanks.
|
@vst I'm going to close this PR as no longer active, please shout if you need it to be reopened |
|
Alright. Sorry, I did not have time to look into that. I will ping you if I can look at it. |
This PR closes #142.
formatWorkbookaccumulates cell merge information (_formattingMerges) along with style information as it iterates over a list of worksheet data.Indeed, this is necessary for
formatCellto process a single worksheet and to conclude with a list of cell ranges for merged cells.However, once we are done with processing a single worksheet, we should reset the accumulated merge information to an empty list so that the next worksheet does not contain cell merges accumulated from previous worksheets' data.