Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward Declare Aliases to Prevent Style Warnings #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Forward Declare Aliases to Prevent Style Warnings #168

wants to merge 1 commit into from

Conversation

rvs314
Copy link

@rvs314 rvs314 commented May 17, 2022

This fixes #165 by declaiming the aliases as functions so that the compiler doesn't emit a style warning.

@stylewarning stylewarning self-requested a review June 3, 2022 19:32
stylewarning
stylewarning requested changes Jun 3, 2022
View reviewed changes
Copy link
Member

@stylewarning stylewarning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is a little superfluous now because the issue has been fixed in another way. It should still be valuable to make these DECLAIMs but I think using t instead of matrix is preferred.

src/high-level/matrix.lisp
@@ -487,6 +487,7 @@ If :SQUARE is T, then the result will be restricted to the upper rightmost squar
(tref matrix i j))))
target))))
;;; Synonym for upper-triangular
(declaim (ftype (function (matrix)) triu))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these aren't necessarily matrix functions, just the implementation provided is

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these were to be replaced with t, would that impair any optimizations?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. There's a lot of indirection already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stylewarning stylewarning stylewarning requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined function warning: DAGGER
2 participants
@rvs314 @stylewarning