Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema version restriction #3160

Open
flying-sheep opened this issue Oct 25, 2022 · 3 comments
Open

Remove schema version restriction #3160

flying-sheep opened this issue Oct 25, 2022 · 3 comments

Comments

@flying-sheep
Copy link
Collaborator

You hardcode the list of supported JSON schema versions to just draft 7.

Is there any reason this is an allowlist instead of a blocklist? Otherwise it should be removed to allow using newer schema versions.

@robnewman
Copy link
Contributor

There is a good reason for this: Quilt uses multiple JSON libraries (e.g. Javascript, Python) across the different parts of the catalog (including IGV visualizations), and that several of these libraries do not support a version of the JSON schema other than draft 7. Unfortunately it's not trivial to simultaneously support multiple drafts at this time. Removing the hardcoded JSON schema version may break parts of the application.

We're definitely looking to simplify this and support newer schema versions in the future, but just not at this moment.

@akarve akarve reopened this Oct 27, 2022
@akarve
Copy link
Member

akarve commented Oct 27, 2022

Leaving this open as it's totally possible (and desirable) to upgrade supported schema versions across JS and Python.

@akarve
Copy link
Member

akarve commented Oct 27, 2022

There's also a deeper point here on white- versus blacklist and backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants