Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4215 more informative error for already a packageentry #4216

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

drernie
Copy link
Member

@drernie drernie commented Nov 14, 2024

Description

Ensure we return sufficient information on errors to enable efficient debugging.

TODO

  • [X ] Unit tests
  • [ X] Changelog entry (skip if change is not significant to end users, e.g. docs only)

@drernie drernie linked an issue Nov 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.80%. Comparing base (5e7ce5d) to head (7acc984).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4216      +/-   ##
==========================================
+ Coverage   37.68%   37.80%   +0.11%     
==========================================
  Files         768      768              
  Lines       35321    35376      +55     
  Branches     5021     5021              
==========================================
+ Hits        13312    13375      +63     
+ Misses      21402    21394       -8     
  Partials      607      607              
Flag Coverage Δ
api-python 91.27% <100.00%> (+0.18%) ⬆️
catalog 12.07% <ø> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drernie drernie marked this pull request as ready for review November 15, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More informative error for "Already a PackageEntry"
1 participant