Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@qcore.retry() doesn't work on classmethods #35

Open
JelleZijlstra opened this issue Jul 27, 2017 · 1 comment
Open

@qcore.retry() doesn't work on classmethods #35

JelleZijlstra opened this issue Jul 27, 2017 · 1 comment

Comments

@JelleZijlstra
Copy link
Collaborator

In the following,

class X:
    @qcore.retry(KeyError)
    @asynq.async()
    @classmethod
    def f(cls): pass
    @qcore.retry(Exception)
    @classmethod
    def g(cls): pass

Neither X.f nor X.g can be called any more.

Fixing this probably requires reimplementing @retry using qcore.decorators.

@SurenNihalani
Copy link
Contributor

Feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants