-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move headers to dedicated libquotient directory #445
Comments
I agree that the headers have some high change to conflict with the headers from the application. This is also why we have neochatroom.h and neochatuser.h in NeoChat. |
TL;DR: yes, certainly; I'm just unsure about capitalisation. The current widespread packaging uses The below is for the sake of documenting the considerations. I thought I'd leave the directory for distros to define (e.g. Debian would use Meanwhile, there's a bit of misalignment between capitalised
Thoughts? |
From my side, I prefer snake over camel, but then it is up to you. Thanks you for the "pedantry" explanation :) |
I like Qt style, and vote for Clang as my second choice. |
I like the Qt style the most and it would make sense since it's a Qt library. This is also what KDE Frameworks are doing. You might want to take a look at https://invent.kde.org/frameworks/extra-cmake-modules/-/blob/master/modules/ECMGenerateHeaders.cmake for the generation of the headers in this style. |
Oh, you even have an ECM macro for that... It doesn't like snake_case headers though, unless I missed something. That basically limits options for (non-forwarding) headers to Clang-style and current style. And yeah, I'll have to consider using Qt-style forwarding headers. |
Description
I am starting a new application based on libQuotient but I am a bit disappointed with headers organisation.
From what I see, I have to include libQuotient headers like this:
I feel that, as this are relatively common file names, it will conflict with end users project headers.
It should be more convenient and standard for a library to expose headers like this:
The text was updated successfully, but these errors were encountered: