New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver constructor with default argument `""` triggers false positive #293

Open

nbenn opened this issue Jul 20, 2023 · 1 comment

Member

nbenn commented Jul 20, 2023

The check performed at

DBItest/R/expectations.R

Line 18 in 8c67927

all(nzchar(act$char_args, keepNA = FALSE)),

confuses a default value of "" with having no default at all.

The text was updated successfully, but these errors were encountered:

Member

krlmlr commented Jul 20, 2023

Yeah, it's terrible. What does the correct implementation look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment