Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change quiet default for build_site() #2578

Open
TimTaylor opened this issue Aug 27, 2024 · 2 comments
Open

Change quiet default for build_site() #2578

TimTaylor opened this issue Aug 27, 2024 · 2 comments

Comments

@TimTaylor
Copy link

I load devtools automatically in my R profile and always check my site rendering with build_site(). By default this wrapper suppresses output (quiet = TRUE). Unfortunately this means you can miss a lot of really useful warning information (particularly the new alt-text warnings that have been added).

As a lot of effort has gone in to the new pkgdown release, in particular the various warnings / information, it seems a shame for this to be hidden. Is it worth considering changing the default to quiet = FALSE?

@jennybc
Copy link
Member

jennybc commented Aug 28, 2024

TBH it's news to me that devtools has a build_site() function! (I inherited this package as a very mature product.)

So as someone who does a lot of package dev and does actually maintain devtools, my local move for this is to use the pkgdown addin or, for more specialized tasks, make pkgdown::build_*() calls in the console. I realize that doesn't totally address your question, but maybe it's interesting to know.

@hadley As pkgdown maintainer and creator of devtools, do you have an opinion here?

Screenshot 2024-08-28 at 2 47 01 PM

@hadley
Copy link
Member

hadley commented Aug 29, 2024

I think it would be ideal if we could just make this a shortcut for calling pkgdown::build_site() in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants