Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The text "Done!" is not showing in the workbench results #1707

Closed
astayleraz opened this issue Oct 14, 2022 · 3 comments
Closed

The text "Done!" is not showing in the workbench results #1707

astayleraz opened this issue Oct 14, 2022 · 3 comments

Comments

@astayleraz
Copy link

We started to see this test fail with build 2022.12.0-daily-267 on Oct 12, 2022 4:05 AM. We have some test testing testthat and they are failing as we are expecting it to show Done! at the end of the results. The test checks for the text Test complete already so that is good but this check fails: expected: [ FAIL 0 | WARN 0 | SKIP 0 | PASS 1 ] Done!

Kevin mentioned it might be it thinks it is not RStudio.

} else if (!self$rstudio) {
self$cat_line(cli::style_bold(" Done!"))
}

Below is the test that we run and the output.

Screen Shot 2022-10-14 at 9 10 31 AM

@hadley
Copy link
Member

hadley commented Mar 23, 2023

Can you provide a bit more detail about exactly how you're running the tests?

@astayleraz
Copy link
Author

astayleraz commented Mar 23, 2023

This is the steps we take to do this and assumes any expected packages are installed.

  1. In the console type .rs.api.executeCommand('newSourceDoc')
  2. Add the following to the source doc:
library(testthat)
test_that("Sample tests", {expect_equal(1, 1)})
  1. Save the file.
  2. Click the Run Tests button.
  3. observe Tests tab output.

expected: [ FAIL 0 | WARN 0 | SKIP 0 | PASS 1 ] Done!

Note: I just ran this now and I see the following which seems odd.

==> Testing R file using 'testthat'

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 0 ]
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 1 ]
Test complete

For now, I just adjusted our tests to expect [ FAIL 0 | WARN 0 | SKIP 0 | PASS 1 ] in the output, so our tests are passing for this currently. Maybe this is all that is expected now?

@hadley
Copy link
Member

hadley commented Mar 24, 2023

The multiple line issue is #1561 come back to life. Sounds like everything else is ok from the IDE side.

@hadley hadley closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants