Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should with_mocked_bindings() follow withr argument style? #1834

Closed
jameslairdsmith opened this issue Jul 10, 2023 · 1 comment
Closed

Should with_mocked_bindings() follow withr argument style? #1834

jameslairdsmith opened this issue Jul 10, 2023 · 1 comment

Comments

@jameslairdsmith
Copy link
Contributor

jameslairdsmith commented Jul 10, 2023

I got momentarily confused using with_mocked_bindings() because I'm used to using withr, where the with_* functions have the temporary state as the first argument, and the code= as the second argument. withr also usually makes new= its own argument rather than using the dots. I don't know if it's worth harmonising with_mocked_bindings() with that pattern?

@hadley
Copy link
Member

hadley commented Jul 26, 2023

I think it's probably too late for that 😞

@hadley hadley closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants