Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sorted diffs in expect_setequal() #1838

Closed
hadley opened this issue Jul 26, 2023 · 1 comment
Closed

Use sorted diffs in expect_setequal() #1838

hadley opened this issue Jul 26, 2023 · 1 comment
Labels
expectation 🙀 feature a feature request or enhancement
Milestone
v3.2.2

Comments

@hadley
Copy link
Member

hadley commented Jul 26, 2023

Should be equivalent to existing approach, but will give better failure messages.
@hadley hadley added feature a feature request or enhancement expectation 🙀 labels Jul 26, 2023
@hadley hadley added this to the v3.3.0 milestone Nov 5, 2024
@hadley
Copy link
Member Author

hadley commented Nov 5, 2024

It's no longer completely clear what you were thinking here, since knowing the position of the values is also useful. In the future, you should provide more details, especially an example.

@hadley hadley closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expectation 🙀 feature a feature request or enhancement
Projects
None yet
Milestone
v3.2.2
Development

No branches or pull requests
1 participant
@hadley