Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_release_issue() should include devtools::check_mac_release()? #1887

Closed
cpsievert opened this issue Aug 16, 2023 · 5 comments
Closed

use_release_issue() should include devtools::check_mac_release()? #1887

cpsievert opened this issue Aug 16, 2023 · 5 comments
Labels
feature a feature request or enhancement release 🛫

Comments

@cpsievert
Copy link
Contributor

I've experienced, a couple time now, that CRAN doesn't run mac checks until after the package is accepted (which then results in a 2-week deadline request to fix the issue, after it's published). So it seems useful to include devtools::check_mac_release() in the pre-flight checklist.

@hadley hadley added feature a feature request or enhancement release 🛫 labels Nov 3, 2023
@hadley
Copy link
Member

hadley commented Nov 3, 2023

Do you not use a mac? Or did something mac-CRAN specific fail?

@cpsievert
Copy link
Contributor Author

I do use a mac, and yes, it was mac-CRAN specific

@jennybc
Copy link
Member

jennybc commented Nov 3, 2023

Somewhat related to r-lib/devtools#2507

@hadley
Copy link
Member

hadley commented Nov 3, 2023

@cpsievert can you be more explicit about what went wrong?

@hadley
Copy link
Member

hadley commented Jul 23, 2024

This hasn't affected us, and we don't have check_mac_devel() yet, so we're going to close. But we'll keep an eye on the situation and we can reconsider in the future.

@hadley hadley closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement release 🛫
Projects
None yet
Development

No branches or pull requests

3 participants