Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnexpectedParameter errors when using KinesisStreamSpecification #9

Closed
MrNoyce opened this issue Aug 1, 2023 · 3 comments · Fixed by #10
Closed

UnexpectedParameter errors when using KinesisStreamSpecification #9

MrNoyce opened this issue Aug 1, 2023 · 3 comments · Fixed by #10
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MrNoyce
Copy link

MrNoyce commented Aug 1, 2023

Hello,

When using Kinesis Data Streams with DynanoDB, the above error is thrown once dynamoDB local is started.

Similar to the fix in #1, the below code fixes the code locally for me.

// line 370 index.js
            if(migration.KinesisStreamSpecification) {
                delete migration.KinesisStreamSpecification;
            }

Could you please look into this I have just moved over to this package and this is a bit of a blocker for me :).

Many thanks,
MrNoyce

@domdomegg domdomegg added enhancement New feature or request good first issue Good for newcomers labels Aug 4, 2023
@domdomegg
Copy link
Member

domdomegg commented Aug 4, 2023

Sure, this definitely sounds like something we can support.

Generally it's probably worth (for us as a library) going through https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html and double checking everything is being removed that shouldn't be passed to the table creation API (see #11).

@domdomegg
Copy link
Member

Fixed in v0.2.43

@MrNoyce
Copy link
Author

MrNoyce commented Aug 6, 2023

Hello @domdomegg,

Thank you for the quick turn around and support on this issue. Thank you also for the tip as the KinesisSpecification property is conditionally used inside my CF template and maybe something isn't being cleaned up / ignored correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants