Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executer, refactor to not parse when SAY #180

Open
theludovyc opened this issue Jan 9, 2023 · 2 comments
Open

Executer, refactor to not parse when SAY #180

theludovyc opened this issue Jan 9, 2023 · 2 comments
Labels
enhancement New feature or request inChangelog Add this pr to changelog

Comments

@theludovyc
Copy link
Collaborator

Currently in SAY (in Executer), we have var sub_results = regex_cache["VARIABLE_IN_STR"].search_all(text)

So we need to have regex things in Executer. It is bad, because Executer should just execute, not parse. Plus we have code duplication between Parser and Executer. And like for #93 , to fix bug, we need to update both Parser and Executer on same things.

To avoid this, we need to refactor Executer.

@theludovyc theludovyc added enhancement New feature or request inChangelog Add this pr to changelog labels Jan 9, 2023
@Jeremi360
Copy link
Contributor

@theludovyc This is a very good idea to don't have any duplication.
Duplication is that what made Blender Game Engine dead.

@theludovyc
Copy link
Collaborator Author

Blender Game Engine, first game engine I use, long time ago...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inChangelog Add this pr to changelog
Projects
None yet
Development

No branches or pull requests

2 participants