Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 sni hostname #270

Open
cole-dda opened this issue Jan 16, 2022 · 3 comments
Open

http2 sni hostname #270

cole-dda opened this issue Jan 16, 2022 · 3 comments

Comments

@cole-dda
Copy link

when test java http2 server, java sni hostname not allow ":",but hey send "host:port" 。such as:

127.0.0.1 is right,but 127.0.0.1:8080 is wrong

@FrenchBen
Copy link

Can you provide a repeatable example of this?

@alexanderstephan
Copy link

@FrenchBen When you run hey -n 1 -c 1 https://duckduckgo.com:1234 you can inspect the sent package with Wireshark (filter with ssl.handshake.extensions_server_name). When you now inspect the corresponding Client Hello package you can see that the port 1234 is actually part of the Server Name field. This is most likely out spec in regards to RFC6066, see https://www.rfc-editor.org/rfc/rfc6066#section-3. Some hosts seem to extract the hostname, but if they do not, this can cause severe issues.

@alexanderstephan
Copy link

Seems like it is already fixed in #225.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants