Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a Visual Studio Code Version #4

Open
mattpilott opened this issue May 13, 2017 · 11 comments
Open

Make a Visual Studio Code Version #4

mattpilott opened this issue May 13, 2017 · 11 comments

Comments

@mattpilott
Copy link

Please please please

@ramonmcros
Copy link
Owner

@matt3224 I don't use Visual Studio Code, so I'll need someone willing to do and mantain that theme. I'll gladly add it to the repository.

Cheers.

@TBVanderley4545
Copy link

I'll investigate this. Don't have a ton of spare time at the moment, but this is a personal project I'll add to my list. Will update as I start doing this.

@ramonmcros
Copy link
Owner

Thank you, @TBVanderley4545! 🙌

@TBVanderley4545
Copy link

Finally got some time to start working on this.

Obviously still a TON of work to be done, but just giving an idea of the theme area (haven't started syntax portion yet).

From what I've seen, VS Code wants you to do full themes instead of just exclusively syntax or exclusively theme.
screen shot 2018-01-04 at 11 31 14 pm

@TBVanderley4545
Copy link

screen shot 2018-01-06 at 4 26 34 pm

Obviously still have plenty of work to do, but just giving a quick idea of a progress check in for HTML.

@ramonmcros
Copy link
Owner

Obviously still have plenty of work to do, but just giving a quick idea of a progress check in for HTML.

Looks great 👍

@TBVanderley4545
Copy link

Just going to continue posting progress pictures here so that they're tracked.

screen shot 2018-01-07 at 10 59 18 pm

In the next few days, I'll modify CSS/LESS and PHP, and I'll create a pull request for this and publish to the VSCode plugins. It'll probably be beta quality at first, but I'll keep going through and updating based on findings and refinement.

@ramonmcros
Copy link
Owner

Good job!

@TBVanderley4545
Copy link

less comparison
css comparison

Just wanted to add two more screenshots. This time it's for LESS and CSS files.

@ramonmcros I know the work probably isn't 100% yet, but I don't have a wealth of large files in my possession for my personal work to check for fringe cases and other languages. My thoughts are:

  • If you're okay with it, I'd like to go ahead and get this published as a VS Code theme soon, then I can continue to refine and field feedback.

  • Probably start a pull request to get this added into the repo for the VS Code perspective.

Let me know if you have any hesitations.

@ramonmcros
Copy link
Owner

@TBVanderley4545 it looks fine to me, let's publish the theme. 👍

@TBVanderley4545
Copy link

it s live

Alrighty. Skeletor version 1 is live on the VSCode marketplace. Will continue to refine and definitely improve the JSON for the theme. Also going to create a pull request shortly to send the code your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants