From 2bfeeb397a0c97e838dffb2ea5b7f58da0f0ac5b Mon Sep 17 00:00:00 2001 From: Jack Lloyd Date: Sat, 3 Aug 2024 22:35:10 -0400 Subject: [PATCH] Add a CI job that builds with all pcurves disabled This area is tricky and it would be fairly easy to miss an issue that occurs only when the fallback BigInt code is used. --- .github/workflows/ci.yml | 3 +++ src/scripts/ci_build.py | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6467774afd0..51ed30da842 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -228,6 +228,9 @@ jobs: - target: docs compiler: gcc host_os: ubuntu-24.04 + - target: no_pcurves + compiler: gcc + host_os: ubuntu-24.04 runs-on: ${{ matrix.host_os }} diff --git a/src/scripts/ci_build.py b/src/scripts/ci_build.py index e95831b9f02..33c32372513 100755 --- a/src/scripts/ci_build.py +++ b/src/scripts/ci_build.py @@ -64,6 +64,7 @@ def known_targets(): 'limbo', 'minimized', 'nist', + 'no_pcurves', 'sanitizer', 'shared', 'static', @@ -206,6 +207,9 @@ def sanitize_kv(some_string): if target in ['minimized']: flags += ['--minimized-build', '--enable-modules=system_rng,sha2_32,sha2_64,aes'] + if target in ['no_pcurves']: + flags += ['--disable-modules=pcurves_impl'] + if target in ['amalgamation', 'cross-arm64-amalgamation', 'cross-android-arm64-amalgamation']: flags += ['--amalgamation']