Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# frozen_string_literal: true #640

Open
apauly opened this issue Jul 31, 2019 · 0 comments
Open

# frozen_string_literal: true #640

apauly opened this issue Jul 31, 2019 · 0 comments

Comments

@apauly
Copy link

apauly commented Jul 31, 2019

Hi,

we're using Axlsx for generating rather large sheets (> 20k rows; > 50 columns).

I think that there could be some quick wins by by applying # frozen_string_literal: true to the CellSerializer class and adjust some of its methods to not modify frozen strings.

Some local profiling showed that this could safe ~1.000.000 object allocations for big sheets.

What do you think about it? If you're open to that, I could prepare a PR.

Best
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant