Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ocaml source code #3

Open
cgeoffroy opened this issue Feb 26, 2012 · 2 comments
Open

remove ocaml source code #3

cgeoffroy opened this issue Feb 26, 2012 · 2 comments

Comments

@cgeoffroy
Copy link
Collaborator

Without considering copyright issue, we are not supposed to "hack" the ocaml source files. So they should be outside of our git repo, in a separate directory, with a clear dependency.
Some $VARIABLE could be setup before compiling to point to the corresponding directory.

Moreover, git is actually tracking some files that are generated during the ./configure step.

@raph-amiard
Copy link
Owner

We are indeed supposed to hack the ocaml source files, since it is not adapted "as is" for the use we intend to make of it. I already had to make some modifications to the interp.c/h source files to make some functions available externally.

But the extent to which we have to hack it will grow when we have to plug VMKit in the project.

I'd gladly be proved wrong about this, in the form of a diff/pull request that shows me how to have the same functionality without hacking in the ocaml source code.

We can then treat the license/copyright issue separately. The configure files can probably be removed right away.

@raph-amiard
Copy link
Owner

Nice, i see that the configure files issue has already been handled !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants