Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Fix Parquet reader when using device_read_async while the destination device buffers are not ready #17077

Open
ttnghia opened this issue Oct 14, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Oct 14, 2024

Similar to the issue with ORC reader with is fixed by #17074, Parquet reader also has similar problem with using device_read_async, when using device_read_async while the destination device buffers are not ready:

auto buffer =
rmm::device_buffer(cudf::util::round_up_safe(io_size, BUFFER_PADDING_MULTIPLE), stream);
auto fut_read_size = source->device_read_async(
io_offset, io_size, static_cast<uint8_t*>(buffer.data()), stream);

We need to fix it ASAP otherwise there is a risk of data corruption.

From the implementation of datasources, I see that this bug only affects reading data from files. In such situations, the host-2-device memcpy ops do not use user-provided stream. Copying data from other host/device buffers to device buffer is not affected.

@ttnghia ttnghia added the feature request New feature or request label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant