Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra NuGet package #73

Open
kows opened this issue Feb 20, 2018 · 2 comments
Open

Extra NuGet package #73

kows opened this issue Feb 20, 2018 · 2 comments

Comments

@kows
Copy link

kows commented Feb 20, 2018

Would it be possible to provide an extra NuGet package which only contains your custom code DLL?
I want to use the "Link" type in ModelsBuilder, which I have in a class library.
Using the current NuGet I get unwanted stuff like everything below App_Plugins.

@ronaldbarendse
Copy link
Contributor

I second this! The DLL should indeed live in a seperate NuGet package, e.g. RJP.UmbracoMultiUrlPicker.Core. Only the AngularJS code that is used for the back-office plugin should be in RJP.UmbracoMultiUrlPicker.

You can't avoid the dependency on UmbracoCms.Core, because the Link class references Umbraco types (IPublishedContent, Udi, constants, etc.).

This would result in the following dependancy tree:

  • RJP.UmbracoMultiUrlPicker (only App_Plugins\RJP.MultiUrlPicker\*)
    • RJP.UmbracoMultiUrlPicker.Core (only RJP.MultiUrlPicker.dll)
      • UmbracoCms.Core

@spideywebdesign
Copy link

+1 for this.
I generally have a core class library project and this is a bit of a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants