Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox problem #525

Open
carol881221 opened this issue Sep 12, 2018 · 3 comments
Open

checkbox problem #525

carol881221 opened this issue Sep 12, 2018 · 3 comments

Comments

@carol881221
Copy link

I have a table with checkbox.
The current number of records is less the per-page.
When click the check all box,
image
Is this correnct or show
image
Is this a bug ?

@ratiw
Copy link
Owner

ratiw commented Sep 12, 2018

@carol881221 Checkbox actually has three states: checked, unchecked, and indeterminate.

The one you point out is the indeterminate state. It occurs when not all checkboxes on the current page were selected. Vuetable will try to determine the correct state of this "select all" checkbox by checking if all, none, or partial the rows in the current page were selected and assigned appropriate state to this checkbox.

So far, in the given picture, all 4 rows appear to be selected, this checkbox should be in "checked" state. It may or may not be the bug, but I think I haven't changed any code related to this function. So, if you can create a sample on CodeSandbox, CodePen, or jsfiddle to reproduce this, it would be easier for me to check it.

@carol881221
Copy link
Author

carol881221 commented Sep 13, 2018

@ratiw Firstly, thank you for your answer.
I use the branch lesson-16 of vuetable-2-tutorial to reappear this problem.
I change to per-page to 7, This problem will appear on the last page.
image
image

@thomasacrosby
Copy link

thomasacrosby commented Jan 25, 2019

i've made pull requests with a patch to fix this

fix to master: #591

fix to next: #592

kapalla pushed a commit to kentix-gmbh/vuetable-2 that referenced this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants