Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the service or ingress annotations be part of the charts #72

Open
bsushmith opened this issue Aug 16, 2022 · 3 comments
Open

Should the service or ingress annotations be part of the charts #72

bsushmith opened this issue Aug 16, 2022 · 3 comments

Comments

@bsushmith
Copy link
Member

bsushmith commented Aug 16, 2022

Summary
Should the service or ingress annotations be part of the charts, since the current values are based on our internal infra, and users can have their own different controllers?

Example:

  • Service annotation
  service:
    annotations:
      projectcontour.io/upstream-protocol.h2c: tcp

https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L33

  • Ingress annotation:
  ingress:
    enabled: true
    annotations:
      kubernetes.io/ingress.class: contour

https://github.com/odpf/charts/blob/main/stable/guardian/values.yaml#L66

Related discussion - #66 (comment)

@bsushmith
Copy link
Member Author

@ravisuhag @rohilsurana @snorlacs WDYT?

@rohilsurana
Copy link
Member

I support that we remove it from here and supply it as a config at time of deployment on our side.

@ravisuhag
Copy link
Member

+1 to @rohilsurana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants