Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function of chpwd #102

Open
FranklinYu opened this issue Jan 1, 2020 · 2 comments
Open

Add function of chpwd #102

FranklinYu opened this issue Jan 1, 2020 · 2 comments
Labels
help wanted Starter Task Good first issue for folks looking to contibure

Comments

@FranklinYu
Copy link
Contributor

chpwd is also a hook function supported by Zsh. Is there any plan to support it?
@rcaloras
Copy link
Owner

rcaloras commented Jan 2, 2020

No plans currently. A naive solution I could think of would probably do something like watch $OLDPWD for any changes on precmd, and if so invoke any chpwd functions set inside a function array.

Doesn't sound too difficult. Feel free to submit a PR @FranklinYu if interested :)

@dimo414
Copy link
Collaborator

dimo414 commented Mar 15, 2020

I imagine you could implement a chpwd hook on top of bash-preexec as is :) Not that it's a bad idea to support directly, but it's not strictly necessary either.

@rcaloras rcaloras added help wanted Starter Task Good first issue for folks looking to contibure labels Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Starter Task Good first issue for folks looking to contibure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rcaloras @dimo414 @FranklinYu