Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up reusable workflows for GHA #15

Open
afuetterer opened this issue Jul 14, 2024 · 2 comments
Open

Set up reusable workflows for GHA #15

afuetterer opened this issue Jul 14, 2024 · 2 comments

Comments

@afuetterer
Copy link
Member

afuetterer commented Jul 14, 2024

I would like to have a few reusable workflows for common CI tasks (e.g. the lint job with pre-commit) in a central location.

They could be used in rdmo and plugins repos like this:

"uses: rdmorganiser/.github/.github/workflows/_lint.yml@main"

Maybe they should live in a "dedicated" top.level workflows or reusable-workflows directory. They could even have their own repo like https://github.com/rdmorganiser/workflows.

This would reduce duplication and have one central place to maintain.

What do you think?

Refs:

@MyPyDavid
Copy link
Member

thanks @afuetterer, this is a really great idea!

For the plugins, for example, this PR rdmorganiser/rdmo-plugins-radar#1 needs to be adapted and included in here so that each plugin can run a sort of 'sanity check' via this common workflow. I'm going to look into it after the current release.

@afuetterer
Copy link
Member Author

Excellent. I remembered vaguely, that there was a discussion on how to test the plugin installation with rdmo and testing config in CI. I see, it was the radar plugin.

I think the "common" CI jobs, like lint, dev-setup etc. can move here.

Testing rdmo is very different from testing a plugin, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants